Fix test break in test_format_logs_with_thoughts_and_command_succeeds #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the expected test result string to match reality. Rename tests similarly since they test the same behavior.
oshoma
added
bug
Closed
|
Sure!
…On Thu, Dec 7, 2023 at 1:03 PM Boqi (Percy) Chen ***@***.***> wrote:
@oshoma <https://github.com/oshoma> Do you want me to take a look at this
if @Eyobyb <https://github.com/Eyobyb> is busying with other things?
—
Reply to this email directly, view it on GitHub
<#255 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAKWT3AVSPRILYBLU2IRITYIIAILAVCNFSM6AAAAABAJ4SNNSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBVHA2TQNRRGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
20001LastOrder
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the expected test result string to match reality.
Rename tests similarly since they test the same behavior.
See also #254